New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libgit2 v0.23 #540

Merged
merged 2 commits into from Jul 12, 2015

Conversation

Projects
None yet
2 participants
@carlosmn
Member

carlosmn commented Jun 26, 2015

The new release is coming soon, with some large changes in how we deal with remotes, submodules and reflog operations. We don't support enough of submodules for this to be an issue, but the remotes have lost their setters and instead would have to rely on options.

@jdavid jdavid merged commit f09bbe7 into libgit2:master Jul 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdavid

This comment has been minimized.

Member

jdavid commented Aug 2, 2015

Reviewing the commit for API changes. Looks to me that some things cannot be done now:

  • removing remote refspecs, now we can only add
  • setting reflog message in set_head
  • resetting identity to default behaviour

Also, the documentation is not updated.

@carlosmn

This comment has been minimized.

Member

carlosmn commented Aug 2, 2015

You can remove refspecs via the config. What we don't provide anymore is a false sense of ORM in the remote object. There is a convenience method to add entries as that's a common operation and it's trivially doable. Removal has problems with detecing what the right thing to remove is, as well as it not being how many configuration operations are done with git.

The set_head() reflog message was removed as this is a specific operation (switching branches or detaching HEAD) which requires a specific machine-readable message in order for parts of git to behave as expected. Where we can provide these reflog messages, we do.

As for configured ident, if you want to change it only temporarily, you can store the current ident and re-set it after you're done with the impersonation. This kind of behaviour should be really rare.

@jdavid

This comment has been minimized.

Member

jdavid commented Aug 14, 2015

ok thanks, new version released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment