Failure on non-ascii chars in error messages #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libgit2 partially forwards OS error message texts. On non-english Windows OSes these errors may contain non-ascii characters (i.e. umlauts). To avoid that a UnicodeDecodeError is raised the error message is interpreted as UTF-8. The solution should not be necessary on linux/osx as they return always ascii (as far as I know). Thus this solution will not change the behaviour on linux/osx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libgit2 partially forwards OS error message texts.
I.e. the following error message (from C.giterr_last()) is generated on my german windows 10, when a fetch() is done but the remote repo is unavailable:
failed to send request: Das Zeitlimit f\xc3\xbcr den Vorgang wurde erreicht.\r\n.To avoid that a UnicodeDecodeError due to the contained 'ü' (encoded as '\xc3\xbc') is raised the error message must be interpreted as UTF-8.
The solution is not be necessary on linux/osx as they return always ascii (as far as I know).
Thus this solution will not change the behaviour on linux/osx but fix windows issues.