Keep the original filemode on write_archive function #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 1, 2019
0.28.1 (2019-04-19) ------------------------- - Now works with pycparser 2.18 and above `#846 <https://github.com/libgit2/pygit2/issues/846>`_ - Now ``Repository.write_archive(..)`` keeps the file mode `#616 <https://github.com/libgit2/pygit2/issues/616>`_ `#898 <https://github.com/libgit2/pygit2/pull/898>`_ - New ``Patch.data`` returns the raw contents of the patch as a byte string `#790 <https://github.com/libgit2/pygit2/pull/790>`_ `#893 <https://github.com/libgit2/pygit2/pull/893>`_ - New ``Patch.text`` returns the contents of the patch as a text string, deprecates `Patch.patch` `#790 <https://github.com/libgit2/pygit2/pull/790>`_ `#893 <https://github.com/libgit2/pygit2/pull/893>`_ Deprecations: - ``Patch.patch`` is deprecated, use ``Patch.text`` instead
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 19, 2019
0.28.1 (2019-04-19) ------------------------- - Now works with pycparser 2.18 and above `#846 <https://github.com/libgit2/pygit2/issues/846>`_ - Now ``Repository.write_archive(..)`` keeps the file mode `#616 <https://github.com/libgit2/pygit2/issues/616>`_ `#898 <https://github.com/libgit2/pygit2/pull/898>`_ - New ``Patch.data`` returns the raw contents of the patch as a byte string `#790 <https://github.com/libgit2/pygit2/pull/790>`_ `#893 <https://github.com/libgit2/pygit2/pull/893>`_ - New ``Patch.text`` returns the contents of the patch as a text string, deprecates `Patch.patch` `#790 <https://github.com/libgit2/pygit2/pull/790>`_ `#893 <https://github.com/libgit2/pygit2/pull/893>`_ Deprecations: - ``Patch.patch`` is deprecated, use ``Patch.text`` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing #616
I assume this is the correct way of solving this issue and it worked flawlessly in my (limited) tests.