Introduce Odb type #940
Merged
Introduce Odb type #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevault
force-pushed
the
odb
branch
2 times, most recently
from
f591194
to
cb3ba67
Compare
|
Not sure if that Windows failure is actually me. |
|
Looks good, good job! Don't worry about the AppVeyor failure, it's broken for another reason. Could you please just add unit tests for the new features introduced in commit cdc7710 ? |
jdavid
requested changes
Sep 15, 2019
This refactors the Repository type's ODB accessors to a dedicated Odb type and adds a handful of features from <git2/odb.h>.
|
Latest patch fixes indent and adds tests. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this now to start gathering feedback early, since I have little experience with Python's C API. The goal is to eventually support custom ODB backends written in Python. The steps to get here are roughly:
So far
only step 1 is complete.step 1 and some of step 2 are completed.