OdbBackend: initial groundwork #942
Conversation
| "Read raw object data from this odb backend.\n"); | ||
|
|
||
| PyObject * | ||
| OdbBackend_read(OdbBackend *self, PyObject *py_hex) |
There was a problem hiding this comment.
Note, in keeping with the libgit2 API design, I have no intention of refactoring Odb_read to go through this code for the sake of DRY.
|
|
||
| /* XXX: This assumes the default libgit2 allocator is in use and will | ||
| * probably segfault and/or destroy the universe otherwise */ | ||
| free(data); |
|
looks good |
ddevault
force-pushed
the
odb
branch
2 times, most recently
from
c24151e
to
ae8c540
Compare
|
I think the basics are in good shape here. I'm going to implement the rest of the backend interface next and then figure out how to make new backends in Python in a future pull request. |
|
I've fixed the build errors in AppVeyor, now there're some test failures related to this work. |
ddevault
changed the title
|
I've addressed the feedback and I think that this is mergable, except for the build failure. I looked into it and I don't really understand why it's occuring. By my reckoning, this should affect a lot of tests. Can you take a look and tell me what you think? |
|
We've seen these errors before. Looking for a little bit I've found commit 00dd78b which fixed 7 errors (6 of them were PermissionErrors): https://ci.appveyor.com/project/techtonik/pygit2/build/1.0.12/tests Commit af983b9 is likely related as well. |
|
Thanks! |
The rough plan is to make the
OdbBackendtype a fairly straightforward mirror of theodb_backendin libgit2. I'll then be addingLooseOdbBackendandPackOdbBackend, andMempackOdbBackend, which will inherit fromOdbBackendand set the underlyingodb_backendpointer, which should Just Werk based on the approach I have set out so far.The more interesting case is that of user-created
OdbBackendimplementations. I'm not really sure what to do for this yet. The first inch of this work is done in the form of the read call raisingNotImplementedExceptionif the C implementation is NULL, then through some kind of magic I assume I'll be able to set these to function pointers for some kind of proxy into Python code with some kind of magic base class. Or something. ¯\_(ツ)_/¯