Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2 compatibility fix is not yet released #943

Closed
tomstuart opened this issue Dec 1, 2022 · 10 comments
Closed

Ruby 3.2 compatibility fix is not yet released #943

tomstuart opened this issue Dec 1, 2022 · 10 comments

Comments

@tomstuart
Copy link

#935, which fixes a warning in Ruby 3.2, was merged in July but missed the most recent rugged release by two days.

Ruby 3.2 will come out later this month and it’d be great if there was a new version of rugged containing this fix so that people upgrading to Ruby 3.2 don’t get the warning.

Could we have a new release between now and Christmas, please?

@Vasfed
Copy link
Contributor

Vasfed commented Dec 25, 2022

ruby 3.2 is released and rugged install fails

@PikachuEXE
Copy link

@Vasfed Which version did you install and how did you install it?
I install rugged 1.5.0.1 and it's fine
If you install 1.0.1 due to pronto, the fix is in master and not released yet and thus I changed Gemfile to use github instead

@Vasfed
Copy link
Contributor

Vasfed commented Dec 26, 2022

@PikachuEXE you're correct, that was 1.0.1, had to switch both gems to use github

gem 'rugged', github: 'libgit2/rugged', submodules: true
gem 'pronto', '>= 0.11', github: 'prontolabs/pronto', require: false

@abinoam
Copy link

abinoam commented Dec 31, 2022

Hi @Vasfed and @PikachuEXE,

Pronto has a new release.
prontolabs/pronto#437 (comment)

f1sherman added a commit to f1sherman/gitx that referenced this issue Jan 3, 2023
Older versions of `rugged` error when used with Ruby 3.2.0:

libgit2/rugged#943
@gytisgreitai
Copy link

are there any plans to release this to rubygems?

@tomstuart
Copy link
Author

v1.5.1 was just released, but doesn’t include #935.

@Aiderlei
Copy link

Aiderlei commented Mar 9, 2023

@tomstuart what is the reason for this? Any updates so far?

I am getting quite a few warnings:

warning: undefining the allocator of T_DATA class Rugged::Repository
warning: undefining the allocator of T_DATA class Rugged::Index
warning: undefining the allocator of T_DATA class Rugged::Patch

@tomstuart
Copy link
Author

No idea, sorry, just summarising what I learned from the commit history. Presumably #935 will be included in the next release, but there hasn’t been one since v1.5.1 in January.

@fnordfish
Copy link

#935 Seems to be included in v1.6.2: https://my.diffend.io/gems/rugged/1.5.1/1.6.2

Weirdly enough there are no v1.6.0 and v1.6.1.

@tomstuart
Copy link
Author

This was indeed fixed in v1.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants