Wrap and introduce get_entry_by_oid #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on non-trivial differences in performance between this method and ordinary get_entry, it has been set as its own method.
vmg
pushed a commit
that referenced
this pull request
Dec 30, 2012
Wrap and introduce get_entry_by_oid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
get_entry_by_oid, which returns a hash entry from a tree, based off the oid sha (instead of index or filename, like plainget_entry). I set this as its own method for clarity and especially because this method has different performance characteristics fromget_entry; in theory we could fold it intoget_entryif we wanted, but I do like this approach for now.Added three unit tests, confirming correct behavior when given a non-existent oid or when given a non-string argument.
cc @vmg