Ignore library search paths returned by pkg-config.
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of adding the output of `pkg-config --libs --static` directly
to `$LDFLAGS`, we append only the `-l` part to `$libs`.
This is to fix an issue where trying to build rugged with a
pre-installed libgit2 version would link against that version.
`pkg-config --libs --static` includes something along the lines
of `-L${libdir}`, where `${libdir}` could point to the folder
containing the pre-installed libgit2 version.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding the output of
pkg-config --libs --staticdirectlyto
$LDFLAGS, we append only the-lpart to$libs.This is to fix an issue where trying to build rugged with a
pre-installed libgit2 version would link against that version.
pkg-config --libs --staticincludes something along the linesof
-L${libdir}, where${libdir}could point to the foldercontaining the pre-installed libgit2 version.
This fixes #351.