Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rugged 0.23b4 #494

Merged
merged 4 commits into from Jun 29, 2015
Merged

Rugged 0.23b4 #494

merged 4 commits into from Jun 29, 2015

Conversation

vmg
Copy link
Member

@vmg vmg commented Jun 29, 2015

No description provided.

@arthurschreiber
Copy link
Member

LGTM. Can you also make sure you bump the version number in the Gemfile.lock?

@vmg
Copy link
Member Author

vmg commented Jun 29, 2015

I'm not sure of why the Gemfile.lock was checked in, but that's a terrible practice for gems. I've removed it and stopped travis from doing deployment installs (??)

@arthurschreiber
Copy link
Member

@vmg The Gemfile.lock is never released with the gem, and I'm pretty sure it should be in the repo.

It is only used when running rake and other stuff using bundle exec .... It ensures tests run with the correct development dependencies. Gemfile and Gemfile.lock don't have any impact on users of the rugged gem.

@arthurschreiber
Copy link
Member

After some clarification, I'm 👍 with dropping Gemfile.lock.

It did not have any impact on dependency resolution when installing/using rugged from another application, but dropping it will allow us to identify potential incompatibilities with new versions of rugged's dependencies earlier and we won't have to update the Gemfile.lock after each version bump anymore.

vmg pushed a commit that referenced this pull request Jun 29, 2015
@vmg vmg merged commit 12f5a54 into master Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants