Use the local ssh for check_connection
and stop hiding online skip
s
#889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_connection
test is failing as user/pass combinations are no longer allowed. Change it to be use the CI-provided network endpoint which also avoids having to figure out if we can access the Internet.While here, I noticed a lack of
S
s on the output and so I went ahead and changed these definition-time skips to be actual skips so we can see when calling the tests that there are tests which we are skipping, instead of hiding them and pretending that all tests ran fine.