Fixups for the 1.3 maintenance series #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently macOS is using rvm as the previous `actions/setup-ruby` did not work there at the time were building this. This change should speed up and unify the versions we run for our tests.
This is to work around issues in CI where the bundler locking tries to select `rubysl` because it doesn't know what our platform is.
As required by newer versions of ruby.
ci: use ruby/setup-ruby for both builds
Dir.exists? has been deprecated since Ruby 2.2 and is being removed in Ruby 3.2
Use Dir.exist? instead of Dir.exists?
Add Ruby 3.1 to the CI matrix
Bump version to 1.3.1
This tag was unfortunately not done on a maintenance branch so these updates were missed during the creation of 1.3.2.
This is to include changes we missed out on due to 1.3.1 being done in a non-standard way. There are no functional changes, just compatibility changes for newer rubies.
carlosmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the odd way 1.3.1 was tagged and released (lack of maintenance branch and a version not matching the libgit2 one) we missed out on some changes from that version here.
These are not functional changes so it's not so bad, but we should still want the compatibility fixes for newer rubies to be taken into consideration, so let's add a 1.3.2.1 version with these fixups, like we should have done instead of 1.3.1.