Fix the CI build with older Rust versions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing with the MSRV (1.46.0) or the Debian Rust package (1.48.0), we must lock predicates-core and predicates-tree at older versions. Add a Cargo.lock.msrv file and use it in CI. But it will not be published to crates.io.
asomers
force-pushed
the
cargo.lock.msv
branch
from
b97a919
to
c260900
Compare
|
There may be an easier way to fix this if we want to just skip the test in CI. Simply add: to the right bit of |
|
Possible alternative here: https://gitlab.com/nbdkit/nbdkit/-/merge_requests/21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with the MSRV (1.46.0) or the Debian Rust package (1.48.0), we must lock predicates-core and predicates-tree at older versions. Add a Cargo.lock.msrv file and use it in CI. But it will not be published to crates.io.