version: add static hpdf_version.h header #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramton
requested changes
Sep 16, 2022
Store the libharu version number values (major/minor/bugfix and suffix) in the C header `include/hpdf_version.h`. Generate `HPDF_VERSION_TEXT` and `HPDF_VERSION_ID` from these values using the C preprocessor. To make the version number available to CMake, add CMake logic that automatically pulls these values from the C header. After this patch, the libharu version number is available to dependents without running CMake first, or without running CMake at all, making the source tree build-system agnostic. All the while retaining the advantage of having to maintain/update the version number at a single place. While here, make sure to include `hpdf_version.h` from `hpdf.h` again, so existing apps do not need to be modified to access the version numbers. This restores compatibility with pre-2.4.1 releases, where version number was accessible from C without custom build steps, and always available to users when including `hpdf.h`. Ref: #237
|
Thanks! (Though, IMHO the bunch of regular expressions are a bit sore to the eye 😄) |
bramton
approved these changes
Sep 22, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the libharu version number values (major/minor/bugfix and suffix) in the C header
include/hpdf_version.h. GenerateHPDF_VERSION_TEXTandHPDF_VERSION_IDfrom these values using the C preprocessor.To make the version number available to CMake, add CMake logic that automatically pulls these values from the C header.
After this patch, the libharu version number is available to dependents without running CMake first, or without running CMake at all, making the source tree build-system agnostic. All the while retaining the advantage of having to maintain/update the version number at a single place.
While here, make sure to include
hpdf_version.hfromhpdf.hagain, so existing apps do not need to be modified to access the version numbers.This restores compatibility with pre-2.4.1 releases, where version number was accessible from C without custom build steps, and always available to users when including
hpdf.h.Ref: #237