New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libui for gralloc on devices without legacy gralloc HAL #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotKit
force-pushed
the
libui_gralloc
branch
2 times, most recently
from
May 8, 2022 16:50
c859e24
to
fa8233c
Compare
This seems to fail to build on some older android bases. On android 5 base I got "ui.c:21:10: fatal error: android/rect.h: No such file or directory" |
NotKit
force-pushed
the
libui_gralloc
branch
3 times, most recently
from
May 11, 2022 20:40
56807d2
to
3bb4334
Compare
Should be fixed now, tested to still compile for motorola-titan with Android 5.1. |
krnlyng
approved these changes
Jan 5, 2023
When building this I get
Probably needs some ui.h header similar to hybris/include/hybris/gralloc/gralloc.h to silence the warnings. |
Can you fix those? Thanks |
…traction This is expected to help in cases where device does not have a gralloc1 HAL that can be dlopened by libhybris (noticed on devices shipped with Android 11).
Depends on 39521d86 and needed on devices without loadable gralloc HAL
mlehtima
approved these changes
Jan 20, 2023
FakeShell
added a commit
to AlpHybris/libhybris
that referenced
this pull request
Apr 8, 2023
…alloc"" This reverts commit f5e4465.
FakeShell
added a commit
to AlpHybris/libhybris
that referenced
this pull request
Apr 8, 2023
…alloc"" This reverts commit f5e4465.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Android 11 devices that shipped with gralloc 4 (for example, device with MediaTek SoCs) there is no gralloc HAL library anymore that can be loaded through libhybris.
This PR tries to implement similar thing to what libhwc2_compat_layer does via libui as that has abstraction over multiple gralloc versions and communicates with gralloc allocator service via HIDL, while still loading the mapper library inside the process.