Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libicu linkage in libical.pc #227

Closed
rossburton opened this issue Feb 4, 2016 · 4 comments
Closed

Fix libicu linkage in libical.pc #227

rossburton opened this issue Feb 4, 2016 · 4 comments

Comments

@rossburton
Copy link

I'm cross-compiling libical in a sysroot and the installed libical.pc looks like this:

prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
threadslib=-lpthread
iculib=/data/poky-master/tmp-glibc/sysroots/intel-corei7-64/usr/lib/libicuuc.so /data/poky-master/tmp-glibc/sysroots/intel-corei7-64/usr/lib/libicui18n.so

Name: libical
Description: An implementation of basic iCAL protocols
Version: 2.0
Libs: -L${libdir} -lical -licalss -licalvcal ${threadslib} ${iculib}
Cflags: -I${includedir}

As you can see the iculib variable doesn't contain -licuuc -licui18n but the full paths to the libraries inside the sysroot. Apart from being ugly, this breaks when the sysroot is moved.

philb pushed a commit to openembedded/openembedded-core that referenced this issue Feb 4, 2016
For now, work around the hardcoded path in the pkgconfig file.
Issue filed upstream as:

libical/libical#227

This raises questions about whether some sanity tests are running.
Those issues will be addressed in a separate patch.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
kraj pushed a commit to YoeDistro/poky-old that referenced this issue Feb 4, 2016
For now, work around the hardcoded path in the pkgconfig file.
Issue filed upstream as:

libical/libical#227

This raises questions about whether some sanity tests are running.
Those issues will be addressed in a separate patch.

(From OE-Core rev: 1b2e1eb)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
@winterz
Copy link
Member

winterz commented Feb 6, 2016

iculibdir=${SYSROOT}/usr/lib
iculib=-licuuc -licui18n
Libs: -L${libdir} -lical -licalss -licalvcal ${threadslib} -L${iculibdir} ${iculib}

any better? I'm not expert in cross-compiling. not sure if there is a standard envvar for the sysroot

@winterz
Copy link
Member

winterz commented Feb 18, 2016

ping? thoughts?

martinmaas pushed a commit to riscvarchive/riscv-poky that referenced this issue Mar 12, 2016
For now, work around the hardcoded path in the pkgconfig file.
Issue filed upstream as:

libical/libical#227

This raises questions about whether some sanity tests are running.
Those issues will be addressed in a separate patch.

(From OE-Core rev: 1b2e1eb6f08b6f95cf555d7f6bc6e4de2113aaed)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
@KrullBorg
Copy link

i don't know how cmake works so i cannot help, but i think it is better to use pkg-config, if the version of libicu provides it

@winterz
Copy link
Member

winterz commented Sep 3, 2016

fixed in 1a41069

@winterz winterz closed this as completed Sep 3, 2016
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
For now, work around the hardcoded path in the pkgconfig file.
Issue filed upstream as:

libical/libical#227

This raises questions about whether some sanity tests are running.
Those issues will be addressed in a separate patch.

(From OE-Core rev: 1b2e1eb6f08b6f95cf555d7f6bc6e4de2113aaed)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
For now, work around the hardcoded path in the pkgconfig file.
Issue filed upstream as:

libical/libical#227

This raises questions about whether some sanity tests are running.
Those issues will be addressed in a separate patch.

(From OE-Core rev: 1b2e1eb6f08b6f95cf555d7f6bc6e4de2113aaed)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants