build: ICU must appear as Requires in pkgconfig #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libical.pc specifies -licu-i18n in its Libs: field, but no Requires: icu-i18n. As a result, the automatic dependency generator in Linux distributions won't see the ICU requirement, won't install it, and builds of secondary software fails. $ gcc icalthing.c `pkg-config libical --cflags --libs` [...] gcc: error: /usr/lib64/libicuuc.so: No such file or directory Move ICU from Libs to Requires, so the dependency scanner can do its job. Specifically move it to Requires.private, since specifying -licu* is not normally needed when libical is a shared library since it already has it recorded in the ELF.
|
there is a problem though, if for some reason icu isnt' found. |
|
Thanks. I am closing this pull request since I just committed a slightly different solution in f70a26a please make sure my fix works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libical.pc specifies -licu-i18n in its Libs: field,
but no Requires: icu-i18n. As a result, the automatic dependency
generator in Linux distributions won't see the ICU requirement,
won't install it, and builds of secondary software fails.
$ gcc icalthing.c
pkg-config libical --cflags --libs[...]
gcc: error: /usr/lib64/libicuuc.so: No such file or directory
Move ICU from Libs to Requires, so the dependency scanner can do its
job. Specifically move it to Requires.private, since specifying -licu*
is not normally needed when libical is a shared library since it
already has it recorded in the ELF.