Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shewchuk's predicates support #1163

Merged
merged 8 commits into from
Apr 20, 2019
Merged

Shewchuk's predicates support #1163

merged 8 commits into from
Apr 20, 2019

Conversation

qnzhou
Copy link
Collaborator

@qnzhou qnzhou commented Apr 19, 2019

Add support for Shewchuk's exact predicates.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@qnzhou qnzhou requested review from jdumas and hankstag April 19, 2019 03:28
@jdumas jdumas added the feature label Apr 19, 2019
jdumas
jdumas requested changes Apr 19, 2019
View reviewed changes
include/igl/predicates/predicates.cpp Outdated Show resolved Hide resolved
include/igl/predicates/predicates.cpp Outdated Show resolved Hide resolved
include/igl/predicates/predicates.cpp Outdated Show resolved Hide resolved
include/igl/predicates/predicates.cpp Outdated Show resolved Hide resolved
@alecjacobson alecjacobson merged commit bc657bc into libigl:dev Apr 20, 2019
@robertliebo robertliebo mentioned this pull request Feb 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hankstag hankstag hankstag left review comments

@jdumas jdumas jdumas approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qnzhou @jdumas @hankstag @alecjacobson