Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set dirty flags for specular and ambient too inside igl::opengl::ViewerData::set_colors(). #1251

Merged
merged 1 commit into from
Jul 28, 2019
Merged

set dirty flags for specular and ambient too inside igl::opengl::ViewerData::set_colors(). #1251

merged 1 commit into from
Jul 28, 2019

Conversation

BruegelN
Copy link
Contributor

@BruegelN BruegelN commented Jul 9, 2019

fixes #1250

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@BruegelN
Copy link
Contributor Author

mmh there is a stalled build: https://travis-ci.org/libigl/libigl/jobs/556410062
Could someone with write access please trigger that build again :)

@jdumas jdumas merged commit b79e837 into libigl:dev Jul 28, 2019
@BruegelN BruegelN deleted the fix-dirty-flag-ViewerData.set_color branch November 13, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumas jdumas jdumas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruegelN @jdumas