Update STL reader. #1628
Merged
Update STL reader. #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnzhou
reviewed
Oct 26, 2020
| Derived::RowsAtCompileTime>=0?Derived::RowsAtCompileTime:0 | ||
| , | ||
| Derived::ColsAtCompileTime>=0?Derived::ColsAtCompileTime:0 | ||
| ); |
There was a problem hiding this comment.
Clang-format can be pretty bad sometimes.
There was a problem hiding this comment.
I gave up on code style for libigl as a whole. Maybe one day we'll adopt a .clang-format file...
qnzhou
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following STLs from Thingi10K were not loading with the previous STL parser:
This PR updates our STL parser (copied over from PyMesh) to fix those issues. Previous code had a lot of
gotoin it so I got scared, and preferred to use another implementation.Check all that apply (change to
[x])