common/userpref: remove X509V3_EXT_cleanup() #1561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building libimobiledevice with libressl 3.9 it fails with an
implicit declaration for X509V3_EXT_cleanup().
This was removed in libressl "because it was part of a dangerous,
incomplete and mostly useless API".
Additionally it doesn't seem to be actually used by libimobiledevice:
"It cleans up the stack containing custom extensions which
libimobiledevice doesn't use, it's only needed after calls to
X509V3_EXT_add{,_list,_alias}()."
Reference: libressl/portable#1050
Signed-off-by: orbea <orbea@riseup.net>
This was referenced Apr 23, 2024
|
Merged with 80d5f46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building libimobiledevice with libressl 3.9 it fails with an implicit declaration for
X509V3_EXT_cleanup().This was removed in libressl "because it was part of a dangerous, incomplete and mostly useless API".
Additionally it doesn't seem to be actually used by libimobiledevice:
"It cleans up the stack containing custom extensions which libimobiledevice doesn't use, it's only needed after calls to X509V3_EXT_add{,_list,_alias}()."
Reference: libressl/portable#1050