Move libxml cleanup code to a plist_cleanup method #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed to master after rebase. |
|
where should we call this plist_cleanup() method? Who is the user? how the method will get invoked? please help |
|
@ajinkyajoshi111 libimobiledevice at head includes this change, so if you just update to head you should be fine. Note that it is fine if this cleanup method is never called at all --- that state will be cleaned-up when the process exits anyway. If a binary wants to call it immediately before exit or when plist functionality is no longer needed that might offer a small benefit, but it's not crucial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spirit of #57 and #68 and the comments made by @FunkyM, @nikias, @cfergeau and @progressnerd, this PR attempts to move the libxml cleanup code introduced by a11e8b1 to a seperate
plist_cleanupmethod. It would be the responsability of the user of libplist to actually call this method if required.Feedback is welcome; I think this multithreading issue is causing quite some of the crashes in libimobiledevice so it would be good to have this addressed.