Skip to content

Commit

Permalink
socket: Return -ETIMEDOUT when select() in socket_read_fd() reached t…
Browse files Browse the repository at this point in the history
…he timeout
  • Loading branch information
nikias committed Jun 12, 2019
1 parent 2501f51 commit ca24570
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions common/socket.c
Expand Up @@ -412,6 +412,10 @@ int socket_check_fd(int fd, fd_mode fdm, unsigned int timeout)
strerror(errno));
return -1;
}
} else if (sret == 0) {
if (verbose >= 2)
fprintf(stderr, "%s: timeout\n", __func__);
return -ETIMEDOUT;
}

This comment has been minimized.

Copy link
@Hixie

Hixie Jun 26, 2019

we're getting reports that this is breaking connections in Flutter:
flutter/flutter#35102
Any chance this can be reverted?

This comment has been minimized.

Copy link
@nikias

nikias Jun 28, 2019

Author Member

The change was required to properly support timeout conditions with SSL connections, so no. Why can't flutter be updated?

This comment has been minimized.

Copy link
@Hixie

Hixie Jul 1, 2019

Sounds like 6539b02 fixed it for us, thanks!

} while (eagain);

Expand Down

0 comments on commit ca24570

Please sign in to comment.