Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not load moneybutton in vue3 #7

Closed
flufy3d opened this issue Sep 7, 2020 · 4 comments
Closed

can not load moneybutton in vue3 #7

flufy3d opened this issue Sep 7, 2020 · 4 comments
Assignees

Comments

@flufy3d
Copy link

flufy3d commented Sep 7, 2020

runtime-core.esm-bundler.js?5c40:formatted:2206 Uncaught TypeError: Cannot create property '0' on boolean 'true'
at normalizePropsOptions (runtime-core.esm-bundler.js?5c40:formatted:2206)
at createComponentInstance (runtime-core.esm-bundler.js?5c40:formatted:5783)
at mountComponent (runtime-core.esm-bundler.js?5c40:formatted:4182)
at processComponent (runtime-core.esm-bundler.js?5c40:formatted:4174)
at patch (runtime-core.esm-bundler.js?5c40:formatted:3793)
at mountChildren (runtime-core.esm-bundler.js?5c40:formatted:3995)
at mountElement (runtime-core.esm-bundler.js?5c40:formatted:3893)
at processElement (runtime-core.esm-bundler.js?5c40:formatted:3875)
at patch (runtime-core.esm-bundler.js?5c40:formatted:3790)
at mountChildren (runtime-core.esm-bundler.js?5c40:formatted:3995)

@libitx
Copy link
Owner

libitx commented Sep 7, 2020

Thanks for the headsup. I've not even tried to get this working in Vue 3 yet but will try and get a vue 3 build ready for v3's stable release.

@flufy3d
Copy link
Author

flufy3d commented Sep 7, 2020

"dependencies": {
"axios": "0.20.0",
"core-js": "^3.6.5",
"express-session": "^1.17.1",
"passport": "^0.4.1",
"passport-moneybutton": "0.0.2",
"socket.io": "^2.3.0",
"vue": "^3.0.0-0"
},

@flufy3d
Copy link
Author

flufy3d commented Sep 7, 2020

now I am using the official js moneybutton lib.
it take almost 10 second to show the button.
it's too slow
do you have some idea to accelerate it?

@libitx libitx self-assigned this Jan 24, 2021
libitx added a commit that referenced this issue Jan 26, 2021
@libitx
Copy link
Owner

libitx commented Jan 26, 2021

Vue3 compatibility is fixed in the master branch. I'll be publishing a new release later this week.

@libitx libitx closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants