Fix clang compatibility of jsimd_arm_neon.S #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang only supports Unified Assembler Language (and not pre-UAL syntax). This is intentional. https://llvm.org/bugs/show_bug.cgi?id=23507 http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/BABJIHGJ.html This means clang expects "strbeq" here. Unfortunately, it seems that my version of gcc only supports "streqb". So I think we need both variations here.
|
I need more specifics on this. clang is used to build iOS code as well, and the versions I'm using on Mac don't seem to exhibit this issue. So I need to understand whether this issue affects only specific versions of clang. |
|
Never mind. I see now that the reason why I wasn't seeing this issue on Mac is that we use |
dcommander
pushed a commit
that referenced
this pull request
May 2, 2016
By design, clang only supports Unified Assembler Language (and not pre-UAL syntax): https://llvm.org/bugs/show_bug.cgi?id=23507 http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/BABJIHGJ.html Thus, clang only supports the strbeq instruction and not streqb, but unfortunately some versions of GCC only support streqb. Go, go Gadget #ifdef... Based on mattsarett@a82e63aac63f8fa3 95fa4caad4de6859623ee2e2 Closes #75
|
Thanks a lot for the speedy integration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang only supports Unified Assembler Language (and not pre-UAL syntax). This is intentional.
https://llvm.org/bugs/show_bug.cgi?id=23507
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/BABJIHGJ.html
This means clang expects "strbeq" here. Unfortunately, it seems that my version of gcc only supports "streqb". So I think we need both variations here.