Skip to content

Commit

Permalink
Fix advice in output for error JXL_ENC_ERR_JBRD (#3572)
Browse files Browse the repository at this point in the history
Updates the message output upon an JXL_ENC_ERR_JBRD error (JPEG
bitstream reconstruction data could not be represented) to suggest
passing --allow_jpeg_reconstruction 0. It previously suggested "Try
using --jpeg_store_metadata 0", which will trigger an unknown-argument
error.

params->jpeg_store_metadata exists but derives its value from
params->allow_jpeg_reconstruction (tools/cjxl_main.cc:921) so I believe
this is the correct parameter to suggest.
  • Loading branch information
trytriangles committed May 13, 2024
1 parent 7e9f6f2 commit 1e3c218
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/extras/enc/jxl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ bool EncodeImageJXL(const JXLCompressParams& params, const PackedPixelFile& ppf,
fprintf(stderr,
"JPEG bitstream reconstruction data could not be created. "
"Possibly there is too much tail data.\n"
"Try using --jpeg_store_metadata 0, to losslessly "
"Try using --allow_jpeg_reconstruction 0, to losslessly "
"recompress the JPEG image data without bitstream "
"reconstruction data.\n");
} else {
Expand Down

0 comments on commit 1e3c218

Please sign in to comment.