Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoder: override color_transform for grayscale JPEG images with AdobeRGB ICC. #250

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Encoder: override color_transform for grayscale JPEG images with AdobeRGB ICC. #250

merged 1 commit into from
Jul 5, 2021

Conversation

eustas
Copy link
Contributor

@eustas eustas commented Jun 30, 2021 •
edited

Otherwise decoder puts all zeroes instead of gray channel.

@eustas eustas requested a review from lvandeve June 30, 2021 11:06
veluca93
veluca93 previously approved these changes Jun 30, 2021
View reviewed changes
@jonsneyers jonsneyers added bug Something isn't working decoder Related to the libjxl decoder labels Jul 1, 2021
@eustas
Copy link
Contributor Author

eustas commented Jul 2, 2021

@lvandeve PTAL

@jonsneyers
Copy link
Member

The following tests FAILED:
1623 - RoundtripTest.FloatFrameRoundtripTest (Failed)

@eustas
Encoder: override color_transform for grayscale JPEG images with Adob…
0617457 
…eRGB ICC.

Otherwis decoder puts all zeroes instead of gray channel.
@eustas eustas added encoder Related to the libjxl encoder and removed decoder Related to the libjxl decoder labels Jul 5, 2021
@eustas
Copy link
Contributor Author

eustas commented Jul 5, 2021

Oh, that is, actually, encoder bug...
PTAL

@eustas eustas changed the title Fix gray JPEG decoding. Encoder: override color_transform for grayscale JPEG images with AdobeRGB ICC. Jul 5, 2021
@eustas eustas mentioned this pull request Jul 5, 2021
Closed
@veluca93
Copy link
Member

veluca93 commented Jul 5, 2021

Oh, that is, actually, encoder bug...
PTAL

facepalm... Nice find!

@eustas eustas merged commit 1a6a9b4 into libjxl:main Jul 5, 2021
@eustas eustas deleted the public248 branch February 4, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvandeve lvandeve lvandeve left review comments

@jonsneyers jonsneyers jonsneyers left review comments

@veluca93 veluca93 veluca93 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working encoder Related to the libjxl encoder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eustas @jonsneyers @veluca93 @lvandeve