Support DQT markers after SOF marker in jpegli decoder. #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsneyers
approved these changes
Apr 18, 2024
|
What happens if the DQT marker is missing? Before, that error was caught too early (it would also trigger if the DQT marker was just later than SOF), but isn't it now not caught at all? |
It is caught in PrepareForScan(), which is called from jpegli_start_decompress(). Do you think it is a problem that it is not caught in jpegli_read_header() ? |
|
It is fine as long as it is caught somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix suggested by @DCNick3
Fixes #3486