Add a new DEC_BOX_COMPLETE event to handle complete boxes without having to wait for *either* DEC_SUCCESS or DEC_BOX #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboukortt
force-pushed
the
box-complete
branch
2 times, most recently
from
ed14f52
to
6355391
Compare
veluca93
reviewed
Jun 20, 2024
veluca93
reviewed
Jun 20, 2024
veluca93
previously approved these changes
Jun 20, 2024
|
It seems this actually breaks a bunch of tests so might need some more work after all. |
|
Fixed. I was afraid of some deeper issue but it turned out to be a relatively trivial change. |
veluca93
reviewed
Jun 20, 2024
veluca93
previously approved these changes
Jun 20, 2024
…ing to wait for *either* DEC_SUCCESS or DEC_BOX
veluca93
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.