Try to fix enc_fast_lossless build (#7223) #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veluca93
reviewed
Jun 20, 2024
eustas
force-pushed
the
cpumodel
branch
9 times, most recently
from
b0a2f6b
to
99cf090
Compare
|
Since this now does not rely on builtin_cpu_supports anymore, this should make dynamic dispatch work on MSVC too, right? Can we re-enable that then? |
|
Yup, why not. |
Drive-by: add standalone enc_fast_lossless target
veluca93
previously approved these changes
Jun 21, 2024
|
Fixed build, please re-stamp |
veluca93
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by: add standalone enc_fast_lossless target