Fix composite key computation for BytesIO #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6GibKm
reviewed
Mar 26, 2024
|
Please add a test to showcase how this can corrupt a db and that it does not happen with this patch. |
Could you take this one over? I do have some higher priority stuff on my stack and this blocks Secrets. |
Sure, thanks for looking into it!! Make sure I am able to push to this branch. |
A6GibKm
force-pushed
the
fix-composite-write
branch
from
8698fdc
to
79dbb28
Compare
|
@Evidlo Hi, this is ready for review. For context, this is corrupting databases on Secrets https://gitlab.gnome.org/World/secrets/-/issues/537. |
Evidlo
reviewed
Apr 3, 2024
Evidlo
reviewed
Apr 3, 2024
janbrummer
force-pushed
the
fix-composite-write
branch
from
79dbb28
to
839508c
Compare
In case a keyfile as BytesIO has been read before, the next read will be empty. We need to ensure that we are reading the data from the beginning. Add seek to start to fix it.
janbrummer
force-pushed
the
fix-composite-write
branch
from
839508c
to
ac2653a
Compare
A6GibKm
added a commit
to flathub/org.gnome.World.Secrets
that referenced
this pull request
Apr 11, 2024
We also update the patch with commit actually merged as part of libkeepass/pykeepass#388.
A6GibKm
added a commit
to flathub/org.gnome.World.Secrets
that referenced
this pull request
Apr 12, 2024
We also update the patch with commit actually merged as part of libkeepass/pykeepass#388.
A6GibKm
added a commit
to flathub/org.gnome.World.Secrets
that referenced
this pull request
Apr 12, 2024
We also update the patch with commit actually merged as part of libkeepass/pykeepass#388.
A6GibKm
added a commit
to flathub/org.gnome.World.Secrets
that referenced
this pull request
Apr 12, 2024
We also update the patch with commit actually merged as part of libkeepass/pykeepass#388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a keyfile as BytesIO has been read before, the next read will be empty. We need to ensure that we are reading the data from the beginning.
Add seek to start to fix it.