-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled extensions #233
Comments
Definitely, this could be a very useful KTX module. I'd have to review each utility during code review, but it looks good so far. The contribution guide has a section on adding new KTX modules. Would you like to set it up and submit a PR? |
cool, will prepare something over the weekend and let you know |
@czyzby : Sorry but I will need your help as I don't know how that works on github. I cloned the repository and checked out the "develop" branch. I followed your guide and created now the new extensions including the tests. I committed them locally but I do not want to click push because that would either fail(?) or I would directly commit to the develop branch which might also not be ideal. edit: or should I create a new branch for my changes? Am I allowed to push a new branch? :D edit2: just tried to create a new branch and push it but it says "Permission to libktx/ktx.git" denied to Quillraven :( |
|
Thanks for the info! I had no idea about that "fork" functionality. I hope I did everything correctly and you should hopefully see my PR without messing up your repo ;) |
Don't worry, you won't. :) I'll review the PR shortly. |
Thanks, I did some minor refactoring and documentation improvements. I also added operator extensions to Thanks again for your contributions! |
You can expect a snapshot release of |
Hi,
just wanted to know if there is an interest in TiledMap extensions as well.
I am using a few in my own game and I could make a pull request if someone is interested.
Just needed to know if this is something useful or not and if it is useful, what do I need to do for a valid pull request? :)
I have following extensions in place for accessing properties
This extension is used to retrieve the shape of a MapObject
Extensions to quickly access properties that are used very often like id, x, y, width, height
With the last extensions, which could be of course created for TiledMap instead of my own Map class you can then do things like this:
The text was updated successfully, but these errors were encountered: