Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gradle wrapper #68

Closed
yhslai opened this issue May 9, 2017 · 5 comments
Closed

Use gradle wrapper #68

yhslai opened this issue May 9, 2017 · 5 comments
Assignees
@czyzby
Labels
dev Miscellaneous issues and dev tasks
Milestone
1.9.6

Comments

@yhslai
Copy link
Contributor

yhslai commented May 9, 2017

Do you think it's a good idea? To ensure everyone uses the same version of Gradle.
@czyzby
Copy link
Member

czyzby commented May 9, 2017

It's the advised approach, although personally I usually end up using the latest Gradle installed locally. Keeping Gradle up to date is a bit of extra maintenance, but I do like the idea of reproducible builds and no Gradle-related Travis problems. Do you want to include the wrapper or should I look into it?

@czyzby czyzby added the dev Miscellaneous issues and dev tasks label May 9, 2017
@yhslai
Copy link
Contributor Author

yhslai commented May 9, 2017

I'll take that then

@czyzby
Copy link
Member

czyzby commented May 9, 2017

Thanks. Use the latest Gradle version.

@czyzby czyzby mentioned this issue May 16, 2017
Closed
10 tasks
@czyzby czyzby added this to the 1.9.6 milestone May 16, 2017
@czyzby czyzby assigned czyzby and unassigned yhslai May 16, 2017
czyzby added a commit that referenced this issue May 16, 2017
@czyzby
Included Gradle wrapper. #68
e15621e
czyzby added a commit that referenced this issue May 16, 2017
@czyzby
Documented usage of the Gradle wrapper. #68
6f0fe44
@czyzby czyzby closed this as completed May 16, 2017
@czyzby
Copy link
Member

czyzby commented May 16, 2017

@raincole I took the task, since it might be pretty useful for contributors and was pretty much trivial to do - I hope you're OK.

@yhslai
Copy link
Contributor Author

yhslai commented May 17, 2017

Surely!

DavidPartouche pushed a commit to DavidPartouche/ktx that referenced this issue Aug 20, 2018
@czyzby @DavidPartouche
Included Gradle wrapper. libktx#68
1df023d
DavidPartouche pushed a commit to DavidPartouche/ktx that referenced this issue Aug 20, 2018
@czyzby @DavidPartouche
Documented usage of the Gradle wrapper. libktx#68
6e1f32d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czyzby czyzby

Labels
dev Miscellaneous issues and dev tasks
Projects
None yet
Milestone
1.9.6
Development

No branches or pull requests
2 participants
@yhslai @czyzby