-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sRGB support #15
Comments
The first two issues should now be fixed. Request sRGB swapchain if needed: app.config.surface.formats = { VK_FORMAT_R8G8B8A8_SRGB };
if (!app.setup())
return error::not_ready; I don't know what to do about the last one (imgui) at the moment. Let's wait and see what happens there 👀 |
FYI: Added FreeType in 89c95f2 - See Gamma Correct Blending
|
Support for sRGB textures and swapchain would be nice to have. sRGB texture formats will perform the conversion to and from linear RGB in hardware. This is important for loading color images (this excludes normal maps, etc.) which are almost always stored as sRGB, as well as applying the correct gamma transformation for display output. You can do it manually, but that's slow, error prone and enforces bad habits.
Currently, three things are blocking this:
_SRGB
formats, but_UNORM
load_texture
doesn't support_SRGB
formats, even though all 4 formats (RGBA, BC, ASTC, ETC2) have SRGB versions. not sure why they're not supported, maybe there's a good reason I'm not aware of.Would appreciate some input 😃 Maybe there's a reason you went without sRGB, or you think it's a non-issue.
The text was updated successfully, but these errors were encountered: