-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to change rendering topology #26
Comments
Ideally there'd be a function for setting that, but exposing every possible pipeline state without any sort of abstraction really blows up the interface. Maybe a more general way of allowing this is to make |
Yes. I also don't think it makes sense to wrap every feature into a function. But having access to all settings at the lowest level makes sense for a prototyping library IMO. |
I find both ideas quite interesting. Maybe we should first switch |
not that I am against it, but what is the advantage on changing parameters from an inherited pipeline over just creating one and changing from the outside? one possible approach could also be to offer a simple interface as is but then have the ability to fine tune the generated pipeline config for advanced use cases. similar to the way the app is initialized. auto pipeline = make_graphics_pipeline(app.device);
pipeline.on_create = [](some_struct_with_all_vulkan_pipeline_params& params){
params.input_assembly_state.topology = VK_PRIMITIVE_TOPOLOGY_POINT_LIST;
}
[EDIT] on_create is probably not quite right. its more something like |
I actually really like that approach 👌 |
Sounds like an elegant solution to the problem. 🚀 If you have time and want to submit a proposal, just do a PR (link it to #26) and we can discuss the approach. |
This PR would solve my problems. I did struggle a bit with consistent naming. Most projects use capital letters for structs and classes. (I dont really care either way) But with lower case I was forced to create the struct create_info and then call the member info. |
Yeah! This is the lava_underscore_flow 🖖 |
I am trying to render a list of vertices as points. So I have changed
input_assembly_state.topology = VK_PRIMITIVE_TOPOLOGY_POINT_LIST
To do so, I just made everything in the pipeline public. What would be the desired way to acomplish this?The text was updated successfully, but these errors were encountered: