Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macos build #86

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Macos build #86

merged 2 commits into from
Jun 10, 2022

Conversation

NorbertoBurciaga
Copy link
Contributor

To be able to compile in macos I had to do two changes:

  1. std::unordered_map is used in livlava/core/hex.hpp in line 56 and there is no #inlcude<unordered_map> defined.
  2. The function tooltips.emplace_back in liblava/app/app.hpp uses the tooltip struct but it requires a constructor, as the tooltip doesn't have a constructor the function fails with the error "..no matching function for call to 'construct_at'..". So a constructor was added to struct tooltip.

@NorbertoBurciaga
To solve liblava/core/hex.hpp:56:22: error: no template named 'unorde…
d14ba1a 
…red_map' in namespace 'std'
@NorbertoBurciaga
a constructor was added to tooltip struct in /liblava/frame/input.hpp…
7dfc011 
… to solve error no matching function for call to 'construct_at' caused by liblava/app/app.hpp tooltips.emplace_back(n, k, m);
@TheLavaBlock TheLavaBlock added the bug Something isn't working label Jun 10, 2022
@TheLavaBlock
Copy link
Member

Thanks. I appreciate it!

@TheLavaBlock TheLavaBlock merged commit 8597948 into liblava:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NorbertoBurciaga @TheLavaBlock