-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
리디 안드로이드 코딩 스타일 리뷰(뷰어팀 PR 템플릿) #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
실행해보니 이런 에러가 나네요
초기 설정을 해줘야 할 게 있을까요? |
우선 로그상 디바이스 assets 사용시점에 문제가 발생하는것으로 보여요 디바이스: Q9 / Android 9(API 29) 실행한 환경 정보 공유해주시면 한번 확인해볼게요 |
- path with "/" doesn't work at API 27 - fixed wrong file path
공유해주신 환경에서 assets에 접근하는 path에 "/" 문제가 있었습니다. |
아래 내용을 반영하겠습니다.
|
- Remove all import of android at XXXViewModel - Single expression - abstract type for argument and return - dispose observable - fix lint warning
금일 피드백 받은 내용 모두 적용 완료하여 Closed합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
환경 정보
스타일 코멘트는 최신 커밋내역에 코멘트를 부탁드리지만 상황에 따라 자유형식으로 의견을 주셔도 됩니다.
요약
목적
관련 링크
후속 작업
주요 확인사항