Skip to content

Commit

Permalink
[#15592081] differentiate verbiage between returned and renewed in fines
Browse files Browse the repository at this point in the history
  • Loading branch information
hgq committed Jul 22, 2011
1 parent 09804e6 commit 3f67c4d
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions C4/Circulation.pm
Expand Up @@ -1880,6 +1880,7 @@ sub _chargeToAccount
sub _FixAccountOverdues { sub _FixAccountOverdues {
my ($issue, $flags) = @_; my ($issue, $flags) = @_;
return unless $issue; return unless $issue;
my $verbiage = $$flags{atreturn}? 'returned' : 'renewed';


$$flags{datedueObj} //= C4::Dates->new($$issue{date_due},'iso'); $$flags{datedueObj} //= C4::Dates->new($$issue{date_due},'iso');
if (ref($$flags{returndateObj}) =~ /C4\:\:Dates/) { if (ref($$flags{returndateObj}) =~ /C4\:\:Dates/) {
Expand Down Expand Up @@ -1941,17 +1942,17 @@ sub _FixAccountOverdues {
$ismax $ismax
); );
##.. then exempt fine ##.. then exempt fine
_checkinDescFine($$issue{borrowernumber},$accountno,$checkindate,$$flags{tolost}) if $$flags{atreturn}; _checkinDescFine($$issue{borrowernumber},$accountno,$checkindate,$$flags{tolost},$verbiage);
_exemptFine($$issue{borrowernumber},$accountno) if ($$flags{exemptfine}); _exemptFine($$issue{borrowernumber},$accountno) if ($$flags{exemptfine});
_logFine($$issue{borrowernumber},"returned item $$issue{itemnumber} $checkindate, $amount due",0) _logFine($$issue{borrowernumber},"$verbiage item $$issue{itemnumber} $checkindate, $amount due",0)
if $$flags{atreturn}; if $$flags{atreturn};
} }
return; return;
} }


## hereafter, we have accountline ## hereafter, we have accountline
if ($$flags{exemptfine}) { if ($$flags{exemptfine}) {
_checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost}) if $$flags{atreturn}; _checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost},$verbiage);
_exemptFine($$issue{borrowernumber},$$row{accountno}); _exemptFine($$issue{borrowernumber},$$row{accountno});
_rcrFine($issue,$row,0); _rcrFine($issue,$row,0);
_logFine($$issue{borrowernumber},"exempt fee item $$issue{itemnumber}",1); _logFine($$issue{borrowernumber},"exempt fee item $$issue{itemnumber}",1);
Expand All @@ -1967,6 +1968,7 @@ sub _FixAccountOverdues {
WHERE borrowernumber = $$issue{borrowernumber} WHERE borrowernumber = $$issue{borrowernumber}
AND accountno = $$row{accountno} AND accountno = $$row{accountno}
"); ");
$msg .= ", $verbiage $checkindate" if !$$flags{tolost};
_rcrFine($issue,$row,0); _rcrFine($issue,$row,0);
_logFine($$issue{borrowernumber},$msg,1); _logFine($$issue{borrowernumber},$msg,1);
return; return;
Expand All @@ -1991,7 +1993,7 @@ sub _FixAccountOverdues {
($amount, undef, undef, undef, $ismax) ($amount, undef, undef, undef, $ismax)
= C4::Overdues::CalcFine($item, $borrower->{categorycode}, $branchcode, = C4::Overdues::CalcFine($item, $borrower->{categorycode}, $branchcode,
undef, undef, $start_date, $enddateObj); undef, undef, $start_date, $enddateObj);
$msg = "adjusted backdate returned item $$issue{itemnumber} $checkindate"; $msg = "adjusted backdate $verbiage item $$issue{itemnumber} $checkindate";
} }


if ($amount && ($amount != $$row{amount})) { if ($amount && ($amount != $$row{amount})) {
Expand Down Expand Up @@ -2036,12 +2038,12 @@ sub _FixAccountOverdues {
C4::Overdues::UpdateFine( C4::Overdues::UpdateFine(
$issue->{itemnumber}, $issue->{borrowernumber}, $amount, undef, $start_date->output,$ismax $issue->{itemnumber}, $issue->{borrowernumber}, $amount, undef, $start_date->output,$ismax
); );
_checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost}); _checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost},$verbiage);
} }
_logFine($$issue{borrowernumber},$msg || "returned item $$issue{itemnumber} $checkindate",1); _logFine($$issue{borrowernumber},$msg || "$verbiage item $$issue{itemnumber} $checkindate",1);
} }
elsif ($$row{accountno} !~ /returned $checkindate/) { elsif ($$row{accountno} !~ /(returned|renewed) $checkindate/) {
_checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost}); _checkinDescFine($$issue{borrowernumber},$$row{accountno},$checkindate,$$flags{tolost},$verbiage);
} }


## bogus ## bogus
Expand Down Expand Up @@ -2289,7 +2291,7 @@ sub _rcrFine


sub _checkinDescFine sub _checkinDescFine
{ {
my $desc = $_[3]? 'checkin as lost' : 'returned'; my $desc = $_[3]? 'checkin as lost' : $_[4];
return C4::Context->dbh->do("UPDATE accountlines return C4::Context->dbh->do("UPDATE accountlines
SET description = CONCAT(description, ', $desc $_[2]') SET description = CONCAT(description, ', $desc $_[2]')
WHERE borrowernumber = ? WHERE borrowernumber = ?
Expand Down

0 comments on commit 3f67c4d

Please sign in to comment.