Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emphmodechars opcode #116

Closed
dkager opened this issue Jul 30, 2015 · 3 comments
Closed

Add emphmodechars opcode #116

dkager opened this issue Jul 30, 2015 · 3 comments
Assignees
Labels
enhancement An enhancement in the functionality (not a bug fix or a table improvement)
Milestone

Comments

@dkager
Copy link
Contributor

dkager commented Jul 30, 2015

Re: feature/ueb_update_code

For the Dutch braille tables (defined in nl-g0.utb) it is desirable to have an emphmodechars opcode. The behavior is similar to capsmodechars, with the following differences:

  • The opcode works on the italic, bold and underline typeforms.
  • The opcode does not affect the detection of these typeforms. Rather, it specifies which braille symbols are defined to end 'emphasis mode', thus requiring another emphasis indicator if emphasis continues beyond these symbols.

The default behavior without this opcode defined is to consider all characters to continue 'emphasis mode'. Examples (assume the entire phrase is emphasized):
Without emphmodechars:

  • test-test gets one emphasis indicator before the first letter.
  • test!test gets one emphasis indicator before the first letter.

With emphmodechars -:

  • test-test gets one emphasis indicator before the first letter.
  • test!test gets two emphasis indicators, one before the first letter and one right after the exclamation mark. This is because the exclamation mark is not defined to continue 'emphasis mode'.

Edge cases to further investigate:

  • !test
  • test! versus test!
  • !!!
@dkager
Copy link
Contributor Author

dkager commented Jan 5, 2016

This has been superseded by #99. I had some trouble with the implementation, so will suspend this and instead try to generalize capsmodechars after the opcode unification/renaming is done.

@dkager dkager closed this as completed Jan 5, 2016
@bertfrees bertfrees reopened this May 28, 2019
@bertfrees bertfrees self-assigned this May 28, 2019
@bertfrees bertfrees added the enhancement An enhancement in the functionality (not a bug fix or a table improvement) label May 28, 2019
@bertfrees
Copy link
Member

@bertfrees bertfrees added this to the 3.10 milestone May 29, 2019
@egli
Copy link
Member

egli commented Jun 3, 2019

Fixed in #747

@egli egli closed this as completed Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement in the functionality (not a bug fix or a table improvement)
Projects
None yet
Development

No branches or pull requests

3 participants