Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate work on capitals, emphasis and numbers in UEB by APH #50

Closed
2 tasks done
bertfrees opened this issue Feb 12, 2015 · 4 comments
Closed
2 tasks done
Assignees
Milestone

Comments

@bertfrees
Copy link
Member

bertfrees commented Feb 12, 2015

  • EndEmphasisPatch.txt can be integrated right away, Mike's further work on emphasis will not rely on that patch.
  • Eventually integrate Mike's mrg-emphasis mrg_ueb_update branch. APH will try to keep their fork in sync with master.

Some relevant posts/threads on mailing list:

Some related issues:

See also the wiki article https://github.com/liblouis/liblouis/wiki/New-opcodes-for-UEB


Overview of the changes:

  • Fixed the behavior of emphasis opcodes.
  • Extended the set of opcodes to cover more use cases.
  • Handle capitalization like other emphasis.
  • Handle script indication like other emphasis.
  • Added 5 other typeform indications (correspond to 5 transcriber-defined indicators in UEB).
firstword*
lastwordbefore*
lastwordafter*
len*phrase
firstletter*
lastletter*
singleletter*
*word
*wordstop

* = {ital, bold, under, caps, script, trans1, trans2, trans3, trans4, trans5}
  • Introduced the typeform bits "passage_break" and "word_reset" to give the user more control.
  • Added the opcode numericmodechars for indicating that a character does not terminate the numeric mode.
  • Added various opcodes as a replacement for letsign.
nocontractsign
seqdelimiter
seqbeforechars
seqafterchars
seqafterpattern
numericnocontchars
  • Changed input-output mapping for end indicators.
  • Deprecated some opcodes.
capsign
begcaps
lenbegcaps
endcaps
bertfrees added a commit that referenced this issue Feb 13, 2015
bertfrees added a commit that referenced this issue Feb 25, 2015
@bertfrees bertfrees changed the title Re-integrate work on capitals and emphasis in UEB by APH Re-integrate work on capitals, emphasis and numbers in UEB by APH Mar 3, 2015
@bertfrees bertfrees added this to the 2.6.4 milestone May 22, 2015
@bertfrees
Copy link
Member Author

Some questions from @dkager (w.r.t. the current status of branch dkager_dutch_ueb: snaekobbi/liblouis@d22a56d...8c46f33):

  • Is there a way to specify which chars don't cancel an all-caps phrase?
  • Why are the wrong (parts of) words being emphasized? (maybe write a separate test case and small table for this)
  • Do you need numericmodechars, or is decpoint broken?

@bertfrees
Copy link
Member Author

  • Is there a way to specify which chars don't cancel an all-caps phrase?

There is the word_reset typeform bit for manually specifying "that a word indicator stops at that point in the word and will need to be repeated if it continues", as explained in Re: Capital/Emphasis update. That could work. I suggested to have an opcode, e.g. called wordresetsign or nowordresetsign (Re: Capital/Emphasis update), or caplike as I suggested later (Re: UEB numeric mode update), for defining characters that generate a word_reset bit. But I'm not sure this is implemented or not.

@bertfrees
Copy link
Member Author

  • Why are the wrong (parts of) words being emphasized? (maybe write a separate test case and small table for this)

This issue was solved by adapting the Python bindings. See Re: Questions about UEB patches by Michael Gray and #103.

@egli egli modified the milestones: 2.6.4, 2.6.5 Aug 31, 2015
@egli egli modified the milestones: 2.6.5, 2.6.6 Nov 30, 2015
@egli egli modified the milestones: 3.0 alpha, 2.6.6 Jun 8, 2016
@egli egli modified the milestones: 3.0 alpha-1, 3.0 Jun 17, 2016
@egli
Copy link
Member

egli commented Jun 30, 2016

I think this is basically done. There are some issues still with ueb numeric mode but these will have to be tracked separately

@egli egli closed this as completed Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants