Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conflicting types for ‘FileInfo’ #92

Closed
egli opened this issue May 29, 2015 · 2 comments · Fixed by #94
Closed

conflicting types for ‘FileInfo’ #92

egli opened this issue May 29, 2015 · 2 comments · Fixed by #94
Labels
bug Bug in the code (not in a table)
Milestone
2.6.3

Comments

@egli
Copy link
Member

egli commented May 29, 2015

liblouisutdml fails with liblouis master because of

readconfig.c:68:1: error: conflicting types for ‘FileInfo’

same story here: readconfig.c inlcudes louis.h and defines FileInfo

TBH I don't really know what the best way to fix this would be. In the long run this is quite annoying and limiting to liblouis.
@egli egli added the bug Bug in the code (not in a table) label May 29, 2015
@egli egli added this to the 2.6.3 milestone May 29, 2015
@bertfrees
Copy link
Member

Right. Again liblouis/liblouisutdml#16

@egli
Copy link
Member Author

egli commented May 29, 2015

I think the best solution in this case is to concede that louis.h isn't really private, create a header file that really is and put these declarations in there. Something like louis_private.h or louis_impl.h.
I mean in the end we don't really want to limit ourself by the frivolous carelessness of liblouisutdml.

egli added a commit that referenced this issue Jun 1, 2015
@egli
Move internal definitions for findtable in a separate header file
3ea8bcd 
which is not exported and not visible in liblouisutdml. This should
avoid problems in liblouisutdml and should fix #92.
@egli egli mentioned this issue Jun 1, 2015
Merged
@egli egli closed this as completed in #94 Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in the code (not in a table)
Projects
None yet
Milestone
2.6.3
Development

Successfully merging a pull request may close this issue.

Move internal definitions for findtable in a separate header file liblouis/liblouis
2 participants
@egli @bertfrees