Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in matching of context rules that begin with uppercase letters #1477

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix bug in matching of context rules that begin with uppercase letters #1477

merged 1 commit into from
Dec 4, 2023

Conversation

bertfrees
Copy link
Member

This fixes #1461.

@bertfrees bertfrees requested a review from egli November 24, 2023 12:15
@bertfrees bertfrees added this to the 3.28 milestone Nov 24, 2023
@bertfrees bertfrees added the bug Bug in the code (not in a table) label Nov 24, 2023
@bertfrees bertfrees mentioned this pull request Nov 24, 2023
Closed
@bertfrees bertfrees added the needs news Update to NEWS file needed label Nov 24, 2023
egli
egli approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@egli egli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to make the variable names less cryptic

liblouis/compileTranslationTable.c Outdated Show resolved Hide resolved
liblouis/compileTranslationTable.c Outdated Show resolved Hide resolved
@egli egli removed their assignment Nov 28, 2023
@bertfrees
Copy link
Member Author

I couldn't find suitable less cryptic names. It's hard to find good names for such abstract things. I'll think about it some more.

@bertfrees
Copy link
Member Author

Fixed up the commit with better variable names.

@egli
Copy link
Member

egli commented Nov 28, 2023

Fixed up the commit with better variable names.

Much better, thanks

@bertfrees
Copy link
Member Author

I did some additions to case-sensitivity.yaml. @egli Please have a look again.

@egli egli merged commit 2c5e473 into master Dec 4, 2023
11 checks passed
@egli egli deleted the issue-498-1461 branch December 4, 2023 10:17
egli added a commit that referenced this pull request Dec 4, 2023
@egli
Add a NEWS entry for #1477
3eb45d8
@egli egli removed the needs news Update to NEWS file needed label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egli egli egli approved these changes

Assignees
No one assigned
Labels
bug Bug in the code (not in a table)
Projects
None yet
Milestone
3.28
Development

Successfully merging this pull request may close these issues.

Context opcode does not match when in a capitalized word/passage
2 participants
@bertfrees @egli