Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables/ueb #17

Closed
wants to merge 4 commits into from
Closed

Tables/ueb #17

wants to merge 4 commits into from

Conversation

josephsl
Copy link
Contributor

@josephsl josephsl commented Aug 2, 2014

Initial work on supporting Latin accents in Unified English Braille (test data to follow).

@egli egli added this to the 2.7.0 milestone Aug 11, 2014
@egli
Copy link
Member

egli commented Aug 27, 2014

@josephsl To be honest I don't quite understand what we are supposed to do here. Are we supposed to merge this or will you provide some test data?

@josephsl
Copy link
Contributor Author

Hi,
I'd say merge for now. But if you'd like me to provide test data, I can do that and wait for the release after the September release. Thanks.

mhameed added a commit that referenced this pull request Aug 28, 2014
* jlee_ueb_accents:
  UEB chardefs: added Latin accented letters (acute, grave, umlaut, etc.).

Closes #17
@mhameed
Copy link
Contributor

mhameed commented Aug 28, 2014

Hi,

I think there might have been a slight misunderstanding. The work that Joseph did is against the tables/ueb, which is the rewrite from scratch implementation of the ueb tables using the formal spec, rather than the one in master.

We already have some accent test data, which were failing because accents were not defined. Once I merged this commit, they are now defined, but they seem to give different dot pattern, so this needs looking into. Since Joseph defined these character definitions directly from the rulebook, I suspect the test data to be wrong.

This is something that we have to take up with Ken and his qualified UEB transcriber.

Merged and closed from commit message, hopefully github will notice and resolve the pull request.

Thanks Joseph.

Mesar

@egli egli modified the milestones: 2.8.0, 2.7.0 Nov 21, 2014
@bertfrees bertfrees modified the milestones: 2.7.0, 2.6.2 Mar 9, 2015
@bertfrees bertfrees removed this from the 2.6.3 milestone May 22, 2015
@egli egli modified the milestone: 2.6.6 Dec 1, 2015
@egli
Copy link
Member

egli commented Jun 9, 2016

If I understand this correctly this has been merged

@egli egli closed this Jun 9, 2016
@egli egli modified the milestones: 3.0 alpha, 2.6.6 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants