Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables/de-eurobrl6.dis: fix a type mismatch #345

Merged
merged 4 commits into from May 29, 2017
Merged

tables/de-eurobrl6.dis: fix a type mismatch #345

merged 4 commits into from May 29, 2017

Conversation

hammera
Copy link
Contributor

@hammera hammera commented May 22, 2017

In the tables/de-eurobrl6.dis file, all alphabetic letters defined with lowercase letters after display opcode,except the w character, this is possible a type mismatch.
So, I simple correct following line:
display W 2456
to:
display w 2456

Me lou_translate de-eurobrl6.dis,hu-hu-g1.ctb command give following right results after modifications:

  1. When I type w character, I get right w eurobraille output.

  2. When I type W character, I get right $w eurobraille output, because now need putting the 46 dots capital letter indicator.

  3. If I typed WA characters, I get right $$wa eurobraille output, because now all original letters is a full uppercase word.

If this is possible, please commit this modification before the new Liblouis 3.2.0 release publication.

In the tables/de-eurobrl6.dis file, all alphabetic letters defined with lowercase letters after display opcode,except the w character, this is possible a type mismatch.
So, I simple correct following line:
display W 2456
to:
display w 2456
@egli egli added this to the 3.2 milestone May 22, 2017
@hammera
Copy link
Contributor Author

hammera commented May 26, 2017

Chris, With hungarian related table modifications I want previous doing with new pull request, but unfortunatelly Github merge all commits with the de-eurobrl6.dis table related pull request.

If this is possible, please merge the hungarian grade1 and new grade2 tables related commits into Liblouis 3.2.0 branch before publication.

With hu-hu-g1.ctb table I only add few rules.

The new hungarian Grade2 table is a complete new table with implementing hungarian grade2 contracted braille.
The table passed with following tests my local repository:

  1. Installation test: passed, the hu-hu-g2.ctb and hu-hu-g2_exceptions.cti lands correct the prefix/share/tables directory.

  2. Lou_checktable hu-hu-g2.ctb command: Of course this test passed, this utility doesn't show any error message.

Because my wife and me travelling tomorrow with two weeks a holiday, unfortunatelly Me not enough time to generate a yaml test file this new table related.

I promise you before next september release date I will create a Yaml test file this table too.

Attila

@egli egli merged commit 56ac02e into liblouis:master May 29, 2017
@reiner-dolp
Copy link
Contributor

@hammera you can open a pull request for each branch in your forked repository. Simply create a branch for each feature and select it in the pull request dialog. See official github tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants