Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better C# Bindings #99

Closed
wants to merge 47 commits into from
Closed

Better C# Bindings #99

wants to merge 47 commits into from

Conversation

EggAllocationService
Copy link
Collaborator

The existing C# bindings have a number of problems:

  • Not very idiomatic
  • Use of dynamic preventing usage on platforms without JIT support
  • All code in one file
  • No standard C# documentation comments
  • The name of the List class overlaps with List in the standard library, causing some headaches
  • Not using the .csproj build system would cause some difficulties creating a .nupkg for distribution

This pull request aims to solve these problems, by implementing the following changes:

  • Split Mapper.cs into multiple files
  • Use the .csproj build system
  • Replace usage of dynamic with object wherever possible
  • Replace Get/Set methods with native Properties where appropriate
  • Use the doxygen documentation as a basis for C# xml comments
  • Rename List to MapperList

@EggAllocationService
Recreate C# bindings as a dotnet solution, rename List<T> -> MapperLi…
f4e1320 
…st<T>
@EggAllocationService
CSharp: Refactor: Remove redundant code
1d7f860
@EggAllocationService
CSharp: Code Style: Switch to built-in type names
ba10de6
@EggAllocationService
CSharp: Fix null analysis
e796dd4
@EggAllocationService
CSharp: Code Style: Switch to using var declarations
2fd74ab
@EggAllocationService
CSharp: Add demo project
4ca38d2
@EggAllocationService
CSharp: Remove some usage of dynamic
841520f
@EggAllocationService
CSharp: Convert Time to getter/setter
9c6515e
@EggAllocationService
CSharp: Replace GetIsReady methods with boolean Ready property
1916424
@EggAllocationService
CSharp: Create Maps property on Device
d5d94f2
@EggAllocationService
CSharp: Code Style: Rename generic parameters
1e8b6b9
@EggAllocationService
CSharp: Code Style: Fix protocol enum naming
66a182f
@EggAllocationService
CSharp: Convert MapperList.Count to a property
5d5e0c9
@EggAllocationService
CSharp: Add standard documentation comments to Map.cs
30f7556
@EggAllocationService
CSharp: Add varargs wrapper function
bc8fb4c 
This will allow the C# wrapper to use the mpr_map_new_from_str initializer on Apple Silicon.
@EggAllocationService
CSharp: Reformat using built-in formatter and styler
69974dc
@EggAllocationService
Add NotImplementedException to IEnumerator.Reset
4e85f18
@EggAllocationService
Implement Map from string constructor on Apple Silicon
9c8d035
@EggAllocationService
CSharp: Fixup: Fix DllImport typo in Map
8cab7ab
@EggAllocationService
Change build system to automatically compile wrapper dylib
91537f4 
Still needs conditional compilation checks.
@EggAllocationService
CSharp: Add make clean targets
d111b72
@EggAllocationService
CSharp: Make style checker happy
a29b0c9
@EggAllocationService
CSharp: Comment and C#-ify Signal
983d02d
@EggAllocationService
CSharp: Update README.md
b046091
@EggAllocationService
CSharp: Fixup: Forgot to change device access in Signal.cs
9c90a38
@EggAllocationService
CSharp: Merge poll functions and document.
39789c4
@EggAllocationService
CSharp: Code Style: Run dotnet format
c653ae8
@EggAllocationService EggAllocationService mentioned this pull request May 22, 2024
Closed
@EggAllocationService EggAllocationService marked this pull request as draft May 23, 2024 13:31
@EggAllocationService
CSharp: Refactor Signal to use C#'s event system
0350000
@EggAllocationService
CSharp: Remove unused event code
b6bd7ca
@EggAllocationService
CSharp: change signature of mpr_obj_get_prop_by_key
5dd631b
@EggAllocationService
CSharp: Register pinned delegate for Signal events
bcbee56
@EggAllocationService
CSharp: Change demo program to use events system
2db388a
@EggAllocationService
Merge branch 'event-rewrite' into better-csharp-bindings
c1826d5 
Reworks the event system to use C#'s native event handlers
@EggAllocationService
CSharp: Rename Type enum -> MapperType
1aecd5e 
There's a commonly used class called `Type` in the standard library, and it's probably best to avoid collisions like that
@EggAllocationService
CSharp: Fixup: Fix nullability of event handler in Signal.cs
b39c118
@EggAllocationService
CSharp: Remove unneeded code in demo
6546169
@EggAllocationService
CSharp: Free callbacks on device destruction
f929271
@EggAllocationService
CSharp: Refactor Get methods into Properties in Graph.cs
45f1942
@EggAllocationService EggAllocationService marked this pull request as ready for review May 23, 2024 17:16
@malloch
Copy link
Member

malloch commented May 31, 2024

Merged!

@malloch malloch closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EggAllocationService @malloch