Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listswf: fileOffset odr-violation #56

Open
asarubbo opened this issue Nov 24, 2016 · 4 comments
Open

listswf: fileOffset odr-violation #56

asarubbo opened this issue Nov 24, 2016 · 4 comments

Comments

@asarubbo
Copy link

On 0.4.7 by default listswf has an odr-violation:

=================================================================
==20414==ERROR: AddressSanitizer: odr-violation (0x00000146f440):
  [1] size=4 'fileOffset' read.c:30:5
  [2] size=4 'fileOffset' listaction.c:29:5
These globals were registered at these points:
  [1]:
    #0 0x429cbd in __asan_register_globals /tmp/portage/sys-devel/llvm-3.9.0-r1/work/llvm-3.9.0.src/projects/compiler-rt/lib/asan/asan_globals.cc:309
    #1 0x59d9e8  (/usr/bin/listswf+0x59d9e8)

  [2]:
    #0 0x429cbd in __asan_register_globals /tmp/portage/sys-devel/llvm-3.9.0-r1/work/llvm-3.9.0.src/projects/compiler-rt/lib/asan/asan_globals.cc:309
    #1 0x7f9f331b85c8  (/usr/lib64/libming.so.1+0x6f5c8)

==20414==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'fileOffset' at read.c:30:5
==20414==ABORTING
@strk
Copy link
Member

strk commented Jan 30, 2017

Can you please check against current master branch ? 6dff24b

@asarubbo
Copy link
Author

The behaviour didn't change

I didn't mind check but since nothing was changed in read.c and listaction.c regarding this issue I'm wondering about the nature of the request....

@strk
Copy link
Member

strk commented Jan 30, 2017

Nature of request: I've been distracted, recently came back to find many security fixes by @rbalint via #63 so was hoping he'd fixed these as well. If he didn't, are you up for a patch of your own ?

@strk
Copy link
Member

strk commented Feb 3, 2017

I've no plan to work on ming any soon but I'm happy to review patches and apply them if someone provides them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants