Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please report errors from the library instead of exit()-ing #66

Open
rbalint opened this issue Jan 30, 2017 · 0 comments
Open

Please report errors from the library instead of exit()-ing #66

rbalint opened this issue Jan 30, 2017 · 0 comments

Comments

@rbalint
Copy link
Contributor

rbalint commented Jan 30, 2017

The default error handler now exits which is not ideal for a shared library:

void                                                                                                                                    
error_default(const char *msg, ...)                                                                                                     
{                                                                                                                                       
  va_list args;                                                                                                                         
                                                                                                                                        
  va_start(args, msg);                                                                                                                  
  vfprintf(stderr, msg, args);                                                                                                          
  va_end(args);                                                                                                                         
  exit(EXIT_FAILURE);                                                                                                                   
}

Other parts of the code assume that when errors are reported the execution of the code stops. This may allow memory corruption when the error handler is replaced with something that does not exit().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant