Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the GDC-specific implementation of 'copysign' function #72

Merged
merged 1 commit into from Oct 15, 2022
Merged

Fix typo in the GDC-specific implementation of 'copysign' function #72

merged 1 commit into from Oct 15, 2022

Conversation

ssvb
Copy link
Contributor

@ssvb ssvb commented Oct 15, 2022

Without this GDC 12.2.0 was failing to compile mir-algorithm:

../.dub/packages/mir-core-1.3.12/mir-core/source/mir/math/common.d-mixin-284:284:175: error: undefined identifier ‘x’
../.dub/packages/mir-algorithm-3.16.12/mir-algorithm/source/mir/format_impl.d:19:24: error: template instance ‘mir.math.common.copysign!double’ error instantiating
   19 |     bool neg = copysign(1, c) < 0;
      |                        ^

Without this GDC 12.2.0 was failing to compile mir-algorithm:

../.dub/packages/mir-core-1.3.12/mir-core/source/mir/math/common.d-mixin-284:284:175: error: undefined identifier ‘x’
../.dub/packages/mir-algorithm-3.16.12/mir-algorithm/source/mir/format_impl.d:19:24: error: template instance ‘mir.math.common.copysign!double’ error instantiating
   19 |     bool neg = copysign(1, c) < 0;
      |                        ^
@ssvb
Copy link
Contributor Author

ssvb commented Oct 15, 2022

BTW, what's the best way to run a full set of unittests? GDC doesn't seem to be covered by CI at the moment.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Base: 39.01% // Head: 39.01% // No change to project coverage 👍

Coverage data is based on head (9a9fba1) compared to base (35d3352).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   39.01%   39.01%           
=======================================
  Files          11       11           
  Lines         469      469           
=======================================
  Hits          183      183           
  Misses        286      286           
Impacted Files Coverage Δ
source/mir/math/common.d 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thewilsonator thewilsonator merged commit ef8192a into libmir:master Oct 15, 2022
@9il
Copy link
Member

9il commented Oct 16, 2022

BTW, what's the best way to run a full set of unittests? GDC doesn't seem to be covered by CI at the moment.

I am not sure GDC support is complete. Likely mir.algebraic could never be supported by GDC because it frequently relies on the new compiler fixups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants