fast byElement #82
Closed
fast byElement #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
force-pushed
the
fast_byelement
branch
from
c8b2e4d
to
f7f9c40
Compare
Current coverage is
|
wilzbach
force-pushed
the
fast_byelement
branch
from
f7f9c40
to
e0c1c4e
Compare
| In contrast to byElement, it only returns a bidirectional forward range access. | ||
| However it is faster for such operations. | ||
| */ | ||
| auto byElementIterator(size_t N, Range)(auto ref Slice!(N, Range) slice) |
There was a problem hiding this comment.
This works only for completely dense slices in normal form. This will not work after iteration operators. If slice has completely dense normal form byElement can return an array.
|
Dont spend time for that right now ) We have more important things todo |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I think I read your warning once that
byElementshouldn't be used if RandomAccess is not needed.Well I was wondering whether there is a better way to iterate element-wise through a slice and I didn't find anything, so I quickly wrote it myself.
It is so simple, that I expect this functionality to exist somewhere - so I didn't clean the code well.
In case this is really new, let me know and I am happy to invest more time.