Refactor core.d to separate package #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for sending many PRs! unfortunately, I cannot take my time in this week. let me review next week |
|
No problem.
…On Sun, Oct 22, 2017 at 1:44 PM Shigeki Karita ***@***.***> wrote:
thank you for sending many PRs! unfortunately, I cannot take my time in
this week. let me review next week
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMJWyt3IL3cJROdvZEvo7YzgUKAijrRZks5su37jgaJpZM4QCCGd>
.
|
|
@ShigekiKarita I have moved around the unittests (with a few small changes). I kept many in the package.d file that you originally had there as package-level documentation, but moved a copy of them or created new ones for the other functions for function-specific documentation. |
|
@ShigekiKarita I don't think so. |
|
I will do this separation today with your enriched doc in #18 . just a moment! |
|
@jmh530 I resolved conflicts. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unittests in core.d combine several different functions at once. This makes them more conducive to a package.d in a sub module.
I have refactored core.d into a separate package, the package.d file has the original unittests, and the other modules are different subsets of the original functionality of core.d I attempted to split up the functions based on how this website categorizes them, with a separate module for utility functions that didn't seem to fit.
In addition, I moved the imports into local imports where appropriate.
Future work will involve adding unittests that test each specific function, but I wanted this PR to be more focused.
EDIT: Depending on the order of different PRs that are in the queue, I may need to make some adjustments to this or them depending on the order of their acceptance.