Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install fixes & cleanup #38

Merged
merged 5 commits into from May 10, 2020
Merged

Install fixes & cleanup #38

merged 5 commits into from May 10, 2020

Conversation

benpruitt
Copy link
Contributor

@benpruitt benpruitt commented May 9, 2020 •
edited

Fixes some outstanding issues w/ setup.py as it relates to packaging and windows builds:

  • Support for primer3 compilation on Windows (using MinGW compiler at setup.py runtime)
  • Removes absolute paths that were erroneously included in SOURCES.txt

Closes #37, closes #33.

I also performed some general cleanup of setup.py and updated documentation.

Testing

  • Build, packaging, and tests succeed on supported platforms (macOS, linux)
  • Build and packaging succeed on Windows 10 (not officially supported)

@benpruitt benpruitt requested a review from grinner May 9, 2020 22:19
grinner
grinner approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@grinner grinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benpruitt benpruitt merged commit 355b8b5 into master May 10, 2020
@benpruitt benpruitt deleted the feat/install_cleanup branch May 10, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grinner grinner grinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows compile fail Error during installation: Absolute Path
2 participants
@benpruitt @grinner